Skip to content

add min stake const#2684

Merged
open-junius merged 5 commits into
devnet-readyfrom
add-min-stake-const
May 28, 2026
Merged

add min stake const#2684
open-junius merged 5 commits into
devnet-readyfrom
add-min-stake-const

Conversation

@open-junius
Copy link
Copy Markdown
Contributor

@open-junius open-junius commented May 21, 2026

Description

Add a new const for min stake.

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run ./scripts/fix_rust.sh to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@open-junius open-junius self-assigned this May 21, 2026
@open-junius open-junius added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label May 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2026 •
edited
Loading

🛡️ AI Review — Skeptic (security review)

VERDICT: SAFE

BASELINE scrutiny: open-junius has write permission, established subtensor PR history, no Gittensor allowlist hit; add-min-stake-const -> devnet-ready.

Static review only per Skeptic rules. Reviewed the prefetched PR metadata, prior Skeptic comment, contributor signals, and full patch. The diff does not modify .github/ai-review/* or .github/copilot-instructions.md; the runtime change replaces the hardcoded default min stake with a config constant set to the same value, wires mocks/runtime config, bumps spec_version, and updates generated contract-test lock metadata.

Findings

No findings.

Conclusion

No malicious behavior or security vulnerability found in the static diff. The change does not add privileged paths, new extrinsics, runtime panic sources, build scripts, Cargo dependency changes, or suspicious supply-chain behavior.

🔍 AI Review — Auditor (domain review)

VERDICT: 👍

LIKELY Gittensor-associated established contributor: repo writer with substantial recent subtensor PR history; no allowlist hit and no same-purpose duplicate found in the prefetched open PR list.

The Auditor proposed a replacement PR description, but the current body is non-trivial; not overwriting. Maintainers: ask the Auditor to regenerate if you want it.

No domain findings. The PR narrowly extracts the hard-coded DefaultMinStake value into a Config constant, wires the runtime and all visible test/mock runtimes, and bumps spec_version from 411 to 412.

Validation: static review plus git diff --check passed. I did not run a targeted build/test because the change is a constant extraction with no new extrinsic, migration, storage iteration, or arithmetic path requiring runtime confirmation.

Findings

No findings.

Conclusion

The effective minimum stake remains 2_000_000 RAO while becoming runtime-configurable and visible as pallet metadata. I do not see a domain issue that should block merge.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2026

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

JohnReedV
JohnReedV previously approved these changes May 27, 2026
View reviewed changes
l0r1s
l0r1s previously approved these changes May 27, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@l0r1s l0r1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to bump spec version @open-junius

@open-junius open-junius dismissed stale reviews from l0r1s and JohnReedV via 9fe4e8c May 28, 2026 00:55
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 28, 2026

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@open-junius open-junius requested review from JohnReedV and l0r1s May 28, 2026 13:37
@open-junius open-junius merged commit 2d5a139 into devnet-ready May 28, 2026
211 of 214 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evgeny-s evgeny-s evgeny-s approved these changes

@l0r1s l0r1s l0r1s approved these changes

@sam0x17 sam0x17 Awaiting requested review from sam0x17

@gztensor gztensor Awaiting requested review from gztensor

@JohnReedV JohnReedV Awaiting requested review from JohnReedV

Assignees

@open-junius open-junius

Labels

skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@open-junius @evgeny-s @l0r1s @JohnReedV